feat(sra): LabeledValueRow component#304
Open
OmarBasem wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OmarBasem
changed the title
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
282a08d to
f18a83b
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
9b86dd4 to
494ae1f
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
494ae1f to
c3657ac
Compare
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
f18a83b to
6b71d34
Compare
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
6b71d34 to
d8164fa
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
c3657ac to
5fef093
Compare
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
d8164fa to
ccade14
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
5fef093 to
ef483af
Compare
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
ccade14 to
ef4a17b
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
ef483af to
3c8bcc8
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
3c8bcc8 to
5a6a49f
Compare
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
ef4a17b to
0895697
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
5a6a49f to
89b13ab
Compare
brtkx
reviewed
Jul 14, 2026
| /> | ||
| </button> | ||
| ) : ( | ||
| <Icon |
Collaborator
There was a problem hiding this comment.
This case only renders info icon user can't interact with; it doesn't serve any purpose. IMO we should do two things here:
- Move DataRow to
react-uiand reuse it here. - Add
labelTooltip: stringoptional property and render info icon with tooltip for this case. The consumer shouldn't need to pass the tooltip behavior, unless I'm missing something.
Member
Author
There was a problem hiding this comment.
@brtkx refactored to a single component in react-ui
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
0638825 to
e23c6d4
Compare
OmarBasem
force-pushed
the
omar/address-display-component
branch
from
fcf3314 to
1812dea
Compare
OmarBasem
force-pushed
the
omar/labeled-row
branch
from
e23c6d4 to
5fa8d25
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FS-2389