feat(sra): TokenChainPill component#299
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OmarBasem
changed the title
OmarBasem
force-pushed
the
omar/token-select
branch
from
571296d to
a928508
Compare
OmarBasem
force-pushed
the
omar/token-select
branch
from
a928508 to
1e612e1
Compare
OmarBasem
force-pushed
the
omar/token-select
branch
from
376a412 to
78315f9
Compare
OmarBasem
force-pushed
the
omar/token-select
branch
from
ac2a72d to
fff48b9
Compare
commit: |
There was a problem hiding this comment.
Not part of this PR but once we have UI ready we should also remember to add the same density system we implemented for the wallet.
| className?: string | ||
| } | ||
|
|
||
| export function TokenChainPill({ |
There was a problem hiding this comment.
Isn't this basically a Select primitive with an optional image? Based on its looks and function, it seems like it should be part of react-ui?
There was a problem hiding this comment.
If we did that, we could have this component as Select as well. It just disabled and has chevron hidden.
There was a problem hiding this comment.
That component is already included
There was a problem hiding this comment.
Isn't this basically a Select primitive with an optional image? Based on its looks and function, it seems like it should be part of react-ui?
Currently it is being used in SRA only. If we needed somewhere else, it can then be refactored to react-ui
# Conflicts: # packages/smart-routing-address-react-ui/.storybook/main.ts # packages/smart-routing-address-react-ui/.storybook/preview.tsx # packages/smart-routing-address-react-ui/package.json # packages/smart-routing-address-react-ui/postcss.config.js # packages/smart-routing-address-react-ui/src/components/TokenChainPill/TokenChainPill.stories.tsx # packages/smart-routing-address-react-ui/src/components/TokenChainPill/TokenChainPill.test.tsx # packages/smart-routing-address-react-ui/src/components/TokenChainPill/index.tsx # packages/smart-routing-address-react-ui/src/index.ts # packages/smart-routing-address-react-ui/src/styles.css # pnpm-lock.yaml
OmarBasem
force-pushed
the
omar/token-select
branch
from
fff48b9 to
7f97fa4
Compare
2 participants
Closes FS-2384
Summary
This PR implements TokenChainPill component