Skip to content

logging: mtrace: Reset host and dsp pointer during init #105357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nashif merged 1 commit into from
Mar 16, 2026
+6 −0
Merged

logging: mtrace: Reset host and dsp pointer during init #105357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions subsys/logging/backends/log_backend_adsp_mtrace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,18 @@ static void mtrace_init(void)

slot = adsp_dw_request_slot(&slot_desc, NULL);
#else
struct adsp_debug_slot *slot = (struct adsp_debug_slot *)
ADSP_DW->slots[ADSP_DW_SLOT_NUM_MTRACE];

if (ADSP_DW->descs[ADSP_DW_SLOT_NUM_MTRACE].type == MTRACE_LOGGING_SLOT_TYPE(MTRACE_CORE)) {
return;
}

ADSP_DW->descs[ADSP_DW_SLOT_NUM_MTRACE].type = MTRACE_LOGGING_SLOT_TYPE(MTRACE_CORE);
#endif

slot->host_ptr = 0;
slot->dsp_ptr = 0;
Copy link
Copy Markdown
Contributor

@kv2019i kv2019i Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi I wonder in which conditions this happens. The code does assume these to be zero after hw init, so indeed this go belly up. I just tried on ACE30 system and I see zeros at boot.

Copy link
Copy Markdown
Contributor Author

@ujfalusi ujfalusi Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is reported as part of a Linux kernel PR: thesofproject/linux#5690 (comment)

}

static size_t mtrace_out(int8_t *str, size_t len, size_t *space_left)
Expand Down
Loading