fix taproot crate#1
Merged
zebra-lucky merged 5 commits intozebra-lucky:add-secp256k1-trfrom Dec 27, 2023
Merged
Conversation
Owner
|
Thank your for your work! I'll look more closely in few days. Currently looking for DKG generating only even |
Owner
|
I'll try to check out PR code locally to test |
1f4b852 to
6fdd873
Compare
Owner
|
I've seen proposed changes, and need reread BIP340/341 |
Owner
|
Trying to reproduce a problem without proposed changes. |
Owner
|
A problem with odd tweaked public key is reproduced. Adding proposed changes and testing again. |
Owner
Author
|
awesome I'll clean this up then :) |
Author
|
here you go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure why it's so messy, I can try to create another clean PR if you want :)
the changes are here: https://github.com/mimoo/frost/commits/mimoo/fix5/ and are basically what I pointed out in the comments in ZcashFoundation#584
(if you rebase on top of the latest changes in frost, and run
cargo fmt, then I can create a clean PR)