ringmenu: drop 76 invented extern fp consts for literals (96.454% -> 96.461%) - #17677
Open
SirEnkido wants to merge 2 commits into
Open
ringmenu: drop 76 invented extern fp consts for literals (96.454% -> 96.461%)#17677SirEnkido wants to merge 2 commits into
SirEnkido wants to merge 2 commits into
Conversation
…lain literals; anon pool now aligns with target, code relocs match) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ble order now byte-identical to target Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src/ringmenu.cpp, two commits:extern const float/double kRingMenu*named constants with plain inline literals, so MWCC folds them into the anonymous.sdata2pool and the code fp-relocs align byte-identically with the target (satisfies theAGENTS.mdrule againstextern-as-crutch and biases toward original source)drawCommand's scale as0.8 - 0.25*fabs(angle)so the pooled doubles emit in the target's orderEvidence
main/ringmenufuzzy (report.json): 96.454% → 96.461%build/GCCP01/okpasses); onlysrc/ringmenu.cpptouched/* --INFO-- */headers preserved, no offset tricks or fake symbolsNotes for review
externconstants in favor of real literals — the file now reads much closer to plausible original source.onDraw/onCalc/drawGBA/drawCommand/GetDispCounterwas each traced to documented register-allocation / scheduling / anonymous-pool walls and left unhacked. Details in the commit messages.drawCommand's scale literal is written as the exact(double)0.8fvalue for byte-identical pool matching — intentional, flagged for transparency.Produced by Claude agents following
AGENTS.md/WORK_SPLIT.md, operated by @SirEnkido.🤖 Generated with Claude Code