routesrv: discover redis shards without fetching full cluster state#2956
Draft
AlexanderYastrebov wants to merge 1 commit intomasterfrom
Draft
routesrv: discover redis shards without fetching full cluster state#2956AlexanderYastrebov wants to merge 1 commit intomasterfrom
AlexanderYastrebov wants to merge 1 commit intomasterfrom
Conversation
Routesrv supports dynamic discovery of Redis instances using Kubernetes Service, see https://github.com/zalando/skipper/blob/master/docs/tutorials/ratelimit.md#redis-based-cluster-ratelimits Dynamic discovery relies on Kubernetes Dataclient that also fetches Ingresses and RouteGroups and creates routes from them. This change enables dynamic discovery of Redis instances using Kubernetes without fetching Ingresses and RouteGroups. When -kubernetes flag is not set but -kubernetes-redis-service-namespace, -kubernetes-redis-service-name and -kubernetes-redis-service-port are provided then `routesrv` creates Kubernetes dataclient to discover Redis instances but does not use this dataclient to load routes. See previous #2934 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added
the
major
| dataclient routing.DataClient | ||
| ) | ||
| if opts.Kubernetes { | ||
| kdc, err = kubernetes.New(opts.KubernetesDataClientOptions()) |
Contributor
Author
There was a problem hiding this comment.
TODO: close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routesrv supports dynamic discovery of Redis instances using Kubernetes Service, see https://github.com/zalando/skipper/blob/master/docs/tutorials/ratelimit.md#redis-based-cluster-ratelimits
Dynamic discovery relies on Kubernetes Dataclient that also fetches Ingresses and RouteGroups and creates routes from them.
This change enables dynamic discovery of Redis instances using Kubernetes without fetching Ingresses and RouteGroups.
When -kubernetes flag is not set but
-kubernetes-redis-service-namespace, -kubernetes-redis-service-name and -kubernetes-redis-service-port are provided then
routesrvcreates Kubernetes dataclient to discover Redis instancesbut does not use this dataclient to load routes.
See previous #2934