feat(consensus): disallow version 4 transactions at NU7 - #959
Draft
ValarDragon wants to merge 4 commits into
Draft
feat(consensus): disallow version 4 transactions at NU7#959ValarDragon wants to merge 4 commits into
ValarDragon wants to merge 4 commits into
Conversation
ValarDragon
force-pushed
the
feat/zip2003-disallow-v4-main
branch
from
September 10, 2026 13:51
8f4eec1 to
3ad0a89
Compare
Base automatically changed from
build/nu7-experimental-feature-main
to
main
September 10, 2026 18:54
ValarDragon
force-pushed
the
feat/zip2003-disallow-v4-main
branch
from
September 10, 2026 18:55
3ad0a89 to
f4cc8a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ZIP 2003 deprecates Sprout by disallowing version 4 transactions at NU7. The original implementation in #856 was merged into the unmerged ZIP 218 branch rather than
main, so it needs a focused replacement on the current codebase.Solution
When the off-by-default
nu7-experimentalfeature is enabled, reject version 4 transactions from the configured network exact NU7 activation height onward. Default builds and networks without an explicit NU7 activation continue accepting V4 transactions in post-NU5 eras.Resolve NU7 directly inside
zakura-consensus, avoiding the two publiczakura-chain::Networkhelpers added by #856. A later configured upgrade therefore cannot substitute for an omitted NU7 activation.The build-feature prerequisite landed in #958. This branch is rebased directly onto
mainafter that merge.Testing
cargo test --locked -p zakura-consensus --lib: 235 passed, 1 ignoredcargo test --locked -p zakura-consensus --lib --features nu7-experimental: 235 passed, 1 ignoredcargo test --locked -p zakura-consensus v4_deprecation_boundaryin both build configurationscargo clippy --locked -p zakura-consensus --all-targets -- -D warningscargo clippy --locked -p zakura-consensus --all-targets --features nu7-experimental -- -D warningscargo fmt --all -- --checkmarkdownlint docs/changelog/unreleased/959.md --config .github/.markdownlint.yaml./scripts/changelog.py checkgit diff --checkThe boundary test covers the height immediately before NU7, the activation height, a later height, the default build, the feature-enabled build, and a network that omits NU7.
Changelog
Added
docs/changelog/unreleased/959.md.Specifications & References
Follow-up Work
None.