ci: add native Codex approval adapter for scoped changes - #922
Open
czarcas7ic wants to merge 11 commits into
Open
ci: add native Codex approval adapter for scoped changes#922czarcas7ic wants to merge 11 commits into
czarcas7ic wants to merge 11 commits into
Conversation
|
Warning No auditable source files found in this PR's diff. |
|
To use Codex here, create an environment for this repo. |
czarcas7ic
marked this pull request as ready for review
September 8, 2026 02:41
|
Warning No auditable source files found in this PR's diff. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ValarDragon
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Let eligible CI and deployment changes from authors with Write, Maintain, or Admin access satisfy the approval requirement through the existing native Codex review. Other PRs follow the repository's normal approval process.
Solution
Add a GitHub Actions adapter that checks author permissions, verifies a clean native review of the current commit, and submits approval through a dedicated App. Automatic reviews and ordinary
@codex reviewrequests remain supported after fixes; review commands count only from accounts with Write access or higher. Eligible Rust and Cargo.toml changes require their own changelog fragment; release helpers and release-policy waivers stay excluded. The App withdraws approvals when evidence stops qualifying, including after retargeting away from main, and can restore its own withdrawals while respecting human dismissals. The first approval starts a Slack thread in #gh-alerts; withdrawals and reapprovals reply there. Delivery receipts prevent repeated notifications, and uncertain Slack delivery requires operator reconciliation without changing the GitHub approval.Setup uses repository Actions secrets and identity variables, with no environment, reviewer team, or rule changes. The adapter starts in read-only mode. Manual-result correlation depends on visible comments; deleted-request ambiguity is an accepted limitation for trusted authors. Withdrawal after changes is asynchronous and preserves the existing merge policy.
Testing
112 offline regression tests pass, covering native evidence, permissions, file eligibility, withdrawal recovery, and Slack approval cycles, retries, and failures. Actionlint, zizmor, Python lint, Markdown lint, and spelling checks pass. Earlier live read-only checks verified the author preflight and native evidence handling. Live App approval and Slack delivery still require activation validation. Used Codex for implementation, tests, and documentation.