fix(build): enable RocksDB libclang loading - #905
Draft
czarcas7ic wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Isolated RPC rustdoc builds fail in RocksDB's binding generator with
a libclang shared library is not loaded on this thread. RocksDB's default features are disabled, leaving its bindgen runtime loader disabled too. Workspace builds can mask this by unifying bindgen features; an unlocked dependency graph with two bindgen versions exposes the missing loader.Solution
Explicitly enable RocksDB's
bindgen-runtimefeature so its binding generator loads libclang independently of other dependencies. Extend the existing isolated semver dependency repair to give published baseline versions the same loader; both sides still undergo the full API comparison.Testing
Locked Cargo metadata, the state crate's feature graph, formatting, and diff checks passed. The feature graph now connects RocksDB directly to bindgen's runtime loader without changing Cargo.lock. CI now builds and parses the current RPC and consensus rustdoc successfully. The baseline repair passes its local source-patching and unexpected-version rejection checks, ShellCheck, and the six semver-selection tests. The full semver workflow now passes, including RPC, consensus, and the other ten package comparisons.
Changelog
Added a library-consumer changelog fragment; fragment validation and Markdown lint passed.
Used Codex to diagnose the failure and prepare the fix and description.