test(network): prototype GetBlocks regulation properties - #860
Draft
evan-forbes wants to merge 2 commits into
Draft
test(network): prototype GetBlocks regulation properties#860evan-forbes wants to merge 2 commits into
evan-forbes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Exercise the peer-message addition contract on one concrete request.
GetBlocksneeds property checks for its wire bounds, invalid ranges, canonical encoding, and specification-defined Work charge.Solution
GetBlocksdeclaration for payload, allocation, range, and Work bounds.GetBlocksranges that extend aboveHeight::MAX.This draft does not claim full regulation conformance. The production Work bucket,
Delay, concurrency slots, and terminal refunds remain follow-up work.Testing
cargo test -p zakura-network block_sync::property_tests -- --nocapturecargo test -p zakura-network zakura::transport::registry::tests -- --nocapturecargo test -p zakura-network codec_ -- --nocapturecargo test -p zakura-network inbound_frame_cap_rejects_over_message_frame_before_reading_payload -- --nocapturecargo clippy -p zakura-network --lib --tests --no-deps -- -D warningscargo fmt --all -- --checkcodespellon the changed design and specification documentsChangelog
Added the explicit internal-only fragment at
docs/changelog/unreleased/860.md.Specifications & References
Built on the peer message regulation design and specification in #747.
Follow-up Work
Implement the production serving Work bucket,
Delay, concurrency-slot ownership, terminal refunds, and the stateful two-peer comparison.