Conversation
Port the wallet-side changes from valargroup/librustzcash#76 and pin the coherent Common NU7 dependency graph. Co-authored-by: Evan Forbes <evan.samuel.forbes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the Zakura wallet stack to the immutable Common NU7 revision from zakura-core/common#474 and exposes NU7 through the wallet APIs without
zcash_unstable="nu7".The dependency graph now uses Common's address, protocol, transparent, and ZIP 321 packages as one coherent type family. It also removes the obsolete ZIP 233 feature surface, matching Common's existing API, and teaches workspace generation to preserve immutable Git revisions.
This ports the applicable wallet-side changes from valargroup/librustzcash#76. Evan Forbes is credited as a co-author on the implementation commit.
Validation:
./scripts/verify-zakura-graph.sh./scripts/verify-wallet-lib-modes.shcargo fmt --all -- --checkgit diff --check