Repository navigation
Spend dynamic-key notes first in spare input slots - #123
Open
czarcas7ic wants to merge 31 commits into
Open
czarcas7ic wants to merge 31 commits into
czarcas7ic wants to merge 31 commits into
Conversation
czarcas7ic
added this pull request to stack #125
October 7, 2026 21:59
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
from
October 7, 2026 22:43
fabbdee to
cc88198
Compare
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
2 times, most recently
from
October 8, 2026 00:55
b370480 to
716e65b
Compare
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
3 times, most recently
from
October 8, 2026 16:14
357dad6 to
f575e6f
Compare
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
from
October 8, 2026 16:44
f575e6f to
4728c2e
Compare
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
from
October 8, 2026 17:26
4728c2e to
7c475da
Compare
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
from
October 8, 2026 21:37
7c475da to
ddad610
Compare
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
from
October 8, 2026 21:58
ddad610 to
974108d
Compare
czarcas7ic
changed the title
With NoteSelection::PreferConsolidation, which Vizor uses for ordinary sends and swap funding, the input selector may add up to the shape's spare input slots without changing the fee. The SQLite store now offers Ironwood dynamic-key notes first among those additions, then the smallest notes, so ordinary sends move their value into ordinary internal change. Funding selection is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
czarcas7ic
force-pushed
the
adam/swap-receiving-slot-filling
branch
from
October 10, 2026 06:07
974108d to
004fd99
Compare
czarcas7ic
marked this pull request as ready for review
October 10, 2026 06:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the funding memo binding, accepted memo identity, feature-independent dynamic key guard, and seen hits stored with the sweep attempt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # librustzcash/zcash_client_sqlite/CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the publishable dynamic-ivk crate, per-attempt directory lookups, sweep reopening on candidate replacement, and stored raw transaction validation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the failed-swap direction fix, the pruning contract, the feature-independent transaction guard and dynamic decryption for ZeWIF imports. The changelog keeps this branch's consolidation sentence with the guard's wording for builds without orchard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9272f14c0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "SELECT {result_columns} | ||
| FROM eligible WHERE lock_tier = :selected_lock_tier | ||
| ORDER BY value ASC, commitment_tree_position, id" | ||
| ORDER BY dynamic_note DESC, value ASC, commitment_tree_position, id" |
There was a problem hiding this comment.
With MultiOutputChangeStrategy, the first dynamic-key candidate can change the wallet metadata and therefore the split-change output count, causing same_change_shape to reject it. The selector only tests prefixes of this ordering, so every subsequent attempt still contains that rejected dynamic note, while later small ordinary notes that could preserve the shape are never tried (and may be omitted entirely when dynamic notes consume the query limit). Thus the new ordering can disable otherwise-valid consolidation instead of falling back to the smallest ordinary candidates.
Useful? React with 👍 / 👎.
Spare-slot filling tries prefixes of the dynamic-first ordering, so a dynamic-key note that changes the change shape stops it. That only misses an optional consolidation; the shared selector stays unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With NoteSelection::PreferConsolidation, which Vizor uses for ordinary sends and swap funding, the input selector may add up to the shape's spare input slots without changing the fee. The SQLite store now offers Ironwood dynamic-key notes first among those additions, then the smallest notes, so ordinary sends move their value into ordinary internal change. Funding selection is unchanged.
Tests: the library CI matrix (fmt, every
scripts/dev.pylane and the three verify scripts) passes at the top of the stack, and the lanes this PR affects pass at this PR.🤖 Generated with Claude Code