Reuse IPA coefficient storage and cache VK expression evaluation - #517
Merged
Merged
Conversation
|
Note Complete: Audit complete. V12 did not find any issues that need review. Open the full results here. Analyzed four files, diff |
ValarDragon
force-pushed
the
perf/ipa-vk-plan-20260928
branch
from
September 27, 2026 23:17
4a68b68 to
cde7006
Compare
This was referenced Sep 27, 2026
Contributor
Author
|
Fable reviewed as well, will merge after rc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #507 into an independently reviewable PR against
main.This contains only the four Halo2 source changes from the validated combined
snapshot
c0eddb54; IFMA arithmetic, affine/prefetch, and point decoding arenot included.
Defer the constant coefficient until Guard consumption, covering every
consumption and scaling path.
sharing common operations while preserving expression and root order.
Pinned-key and transcript hashes are unchanged. No proof or protocol changes.
Validation
Local ARM, Rust 1.97.1 release,
orbits,unstable-verifier-fingerprint:275 unit tests, 7 integration tests, and 9 doctests passed; 4 existing doctests
ignored. Formatting and
git diff --checkpassed. Independent Guard, CSE,dependency, and API review found no blocker. The four Rust files byte-match
the previously validated combined snapshot.
No isolated whole-proof speedup is claimed for this split. The former combined
#507 benchmark included additional optimizations and does not measure this PR
alone. A keygen-warm Apple M4 Max diagnostic measured plan construction at
about 0.38 ms, with 65,672 retained bytes per key, 37,024 scratch bytes per
verification, and 6,176 output bytes per circuit, excluding allocator metadata.
Existing prepared SRS table allocation is unchanged.
API surface
One internal helper is added:
pub(super) MSM::add_owned_g_scalars(&mut self, Vec<C::Scalar>).There are no downstream public,
pub(crate), trait, enum, feature, or existingsignature changes. Private Guard/VK state and derived
Debugoutput change;the evaluation plan is not exposed or included in pinned/transcript hashes.
The corresponding changes are being removed from #507; that PR retains the
IFMA backend and existing decoder.