Skip to content

Fix NU7 consensus branch ID - #492

Closed
ValarDragon wants to merge 1 commit into
mainfrom
fix/nu7-consensus-branch-id
Closed

ValarDragon wants to merge 1 commit into
mainfrom
fix/nu7-consensus-branch-id

Conversation

@ValarDragon

Copy link
Copy Markdown
Contributor

Summary

  • Change the NU7 consensus branch ID to 0x77190AD9 for parsing and serialization.
  • Use a private shared constant for the conversion paths.
  • Update the conversion test and verify the previous ID is rejected.

Testing

  • cargo test -p zakura-protocol (35 passed)

API surface

  • No API surface changes; the new constant is private.

@v12-auditor

v12-auditor Bot commented Sep 23, 2026

Copy link
Copy Markdown

Note

Complete: Audit complete. V12 did not find any issues that need review.

Open the full results here.

Analyzed one file, diff 2c1693b...3b03bb9.

@ebfull

ebfull commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Let's not merge this into main, I'll just fold it into the release PR #490.

ebfull added a commit that referenced this pull request Sep 23, 2026
Bump the workspace version and intra-workspace requirements from
1.3.0-alpha.1 to 1.3.0 and assemble the v1.3.0 changelog sections,
consuming all 17 pending fragments and folding the 1.3.0-alpha.1 sections
into the stable sections.

Editorial changes to the assembled entries:
- Record the #471 dependency swap in zakura-primitives and zakura-keys.
- Link #492 from the #474 NU7 entry: the release ships the 0x77190AD9
  consensus branch ID that the fragment documented.
- Drop the stale `zcash_unstable="nu7"` qualifier from the #458 entry.
- Remove internal-only wording from the #437 and #451 halo2_proofs entries.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ebfull ebfull mentioned this pull request Sep 23, 2026
@ebfull

ebfull commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Folded into #490 (Release 1.3.0) as commit c456029 (cherry-picked with authorship preserved), so 1.3.0 ships the corrected 0x77190AD9 branch ID and the zakura-protocol changelog entry for #474 links this PR.

@ebfull ebfull closed this Sep 23, 2026
ebfull added a commit that referenced this pull request Sep 23, 2026
Bump the workspace version and intra-workspace requirements from
1.3.0-alpha.1 to 2.0.0 and assemble the v2.0.0 changelog sections,
consuming all 17 pending fragments. The bump is major because #471
replaced the `zcash_protocol`, `zcash_transparent`, and `zcash_address`
crates behind types in the public APIs of zakura-primitives and
zakura-keys, and #458 removed the `zip-233` feature and its APIs.

No stable 1.3.0 ships, so the published `1.3.0-alpha.1` sections belong
to the 2.0.0 delta from 1.2.0: they were folded with
`./scripts/changelog.py release v1.3.0` and the section renamed to 2.0.0.

Editorial changes to the assembled entries:
- Record the #471 dependency swap in zakura-primitives and zakura-keys.
- Link #492 from the #474 NU7 entry: the release ships the 0x77190AD9
  consensus branch ID that the fragment documented.
- Drop the stale `zcash_unstable="nu7"` qualifier from the #458 entry.
- Remove internal-only wording from the #437 and #451 halo2_proofs entries.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ebfull ebfull mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants