Repository navigation
ci(release): cut releases through a PR like tihole - #22
Merged
Merged
Conversation
Run gofmt + golines (--max-len=80 --shorten-comments) over the repo, the same formatting gate tihole and whetstone enforce, so the release check added next passes on main. golines treated a //host/share line inside a raw-string fstab fixture in TestParseFstab as a comment and split it, so that fixture is now an interpreted string the formatter leaves alone.
Bring smbark's release flow in line with tihole and whetstone: - just release opens a release/vX.Y.Z PR, waits for CI, squash-merges it and watches the release run instead of tagging locally - release.yml runs when VERSION changes on main (or on a v* tag), re-runs just release-check, creates the tag, runs goreleaser and attests provenance over checksums.txt; re-runs reuse an existing tag - AUR publish stays behind PUBLISH_TO_AUR and skips beta tags - add just prerelease for vX.Y.Z-beta.N tags - add the golines 80-col gate to CI and release-check - pin go, gopls and golines in mise.toml - add the Keep a Changelog header and link footer, and RELEASING.md - drop attest.yml; provenance is attested at release time now Release binaries keep their raw smbark-linux-<arch> names because site/install.sh, the site download links and aur/smbark-bin fetch them.
✅ Deploy Preview for smbark canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings smbark's release flow in line with tihole and whetstone.
What changes
just release patch|minor|majoropens arelease/vX.Y.ZPR, waits for CI, squash-merges it (unless already auto-merged) and watches the release run, instead of tagging locally.release.ymlruns whenVERSIONchanges onmain(or on av*tag push): re-runsjust release-check, creates the tag, runs goreleaser, and attests build provenance overchecksums.txt. Re-running a failed release reuses the existing tag.PUBLISH_TO_AURand now skips beta tags.just prereleaseforvX.Y.Z-beta.Ntags.release-check; go, gopls and golines pinned inmise.toml.CHANGELOG.md; newRELEASING.md.attest.ymlremoved: provenance is attested at release time now.style:commit). A raw-string fstab fixture inTestParseFstabbecame an interpreted string because golines mangled its//host/shareline as a comment.Intentionally different from tihole
Release binaries keep their raw
smbark-linux-<arch>names, not tarballs:site/install.sh, the site download links andaur/smbark-binfetch those exact files.Verification
just release-checkpasses;goreleaser checkvalidates the config.just release patchrun end to end against a local bare remote: version bump, generated 1.2.2 changelog,SECURITY.mdbump, branch, commit and push all correct; it stopped atgh pr createonly because the remote was not GitHub. The merge-and-watch steps get their first real run on the next release.