Skip to content

fix: stop typographer mangling opening quote of quoted 't' words#553

Open
SAY-5 wants to merge 1 commit into
yuin:masterfrom
SAY-5:fix-typographer-t-words
Open

fix: stop typographer mangling opening quote of quoted 't' words#553
SAY-5 wants to merge 1 commit into
yuin:masterfrom
SAY-5:fix-typographer-t-words

Conversation

@SAY-5

@SAY-5 SAY-5 commented May 13, 2026

Copy link
Copy Markdown
  • goldmark is an extensible library. I will no longer accept PRs that add non-CommonMark features to the core parser. Please implement non-CommonMark features as extensions.
    • If you need addtional goldmark functionalities for implementing non-CommonMark features, please create PR that only adds these functionalities without extensions adding non-CommonMark features.
      • DO NOT hesitate copy&paste some logics from goldmark. Copy&paste is not always bad. Many users claim like 'To implement this as an external extension, it would require copy and paste from goldmark, so I implemented it in the core.' . Please copy&paste some logics from goldmark if needed.
    • I welcome PRs that add your extensions to README :)
  • goldmark is a CommonMark parser. I do not discuss about specs here. Please post your questions about CommonMark specs at CommonMark spec repository.

The typographer's 'twas/'em/'net contraction shortcut was triggered by any apostrophe-prefixed word starting with t, so quoted words like 'terrifying' or 'them' lost their opening curly quote. The leading 't shortcut now only fires before w/i ('twas, 'tis, 'twixt, ...), while 'twas and friends still work. Closes #347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single quotes not opening before the letter 't'

1 participant