fsos: add 'cmd :all' block to strip carriage returns and command echo#3849
Open
tlbeaty wants to merge 2 commits into
Open
fsos: add 'cmd :all' block to strip carriage returns and command echo#3849tlbeaty wants to merge 2 commits into
tlbeaty wants to merge 2 commits into
Conversation
…out 'cmd :all', carriage returns were not stripped from output and command echo/prompts were leaking into saved configs. Adding the standard cmd :all block resolves both issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Add
cmd :allblock to strip carriage returns and command echo/promptsfrom device output. Without it,
\rcharacters were appearing in savedconfigs and command echo/prompts were leaking into the output, causing
noisy diffs on every backup.
Tested against FS.com S5860-48SC and S5860-20SQ switches.