ingate: add secret redaction and a model unit test#3845
Open
thanegill wants to merge 4 commits into
Open
Conversation
Ingate is an HTTP model, so it can't use the ATOMS simulation fixtures (those are SSH/telnet only). Add a custom spec (mirroring ivanti_spec) that mocks the node and input, stubs the config download with a representative SIParator export, and asserts the volatile "# Timestamp:" line is stripped while the configuration is kept.
Replace the in-place `gsub!` plus redundant `cfg` return with a single `gsub` in the config command block. Behavior-preserving (covered by the model unit test).
The downloaded SIParator config stores credentials across many fields, so match by suffix to cover them all: passwords (trunkuserpassword, snmppassword, ...), secrets (radiussecret, ...), passphrases (configencpassphrase, ...), pre-shared keys (xauth_psk), HMAC and API tokens (eabhmackey, api_token), the SNMP community, and PEM private keys (cert_key, ...). Lookalikes such as passwordtimeout and enable_psk_rw are left untouched. Field names come from the Ingate reference guide. Covered by the model unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
cmd :secretto redact secrets.