eatonnetwork: add model unit test and simplify the model#3844
Open
thanegill wants to merge 3 commits into
Open
eatonnetwork: add model unit test and simplify the model#3844thanegill wants to merge 3 commits into
thanegill wants to merge 3 commits into
Conversation
Add a device-simulation unit test for the EatonNetwork model (Network-M3 card, firmware 2.2.0) captured from `save_configuration`, plus a secret test covering cmd :secret redaction. The card's JSON config is sanitized (passphrase, cyphered blobs, IPs, emails, hostnames and identification scrubbed); the command key uses the empty passphrase that the test node's nil password produces.
Navigate the JSON config with `dig` instead of long chained `[]` accessors, and operate on each sub-object inside a `tap`/`each` block instead of intermediate local variables. Also parse the config via the `keep_lines` refinement, combine the predefined/created account loops, drop the redundant `cfg = ...; cfg` return assignments, and fix a comment typo.
thanegill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description