tplink: model fix and added TP-Link DeltaStream GPON OLT unit tests and model notes#3832
Open
Vantomas wants to merge 2 commits into
Open
tplink: model fix and added TP-Link DeltaStream GPON OLT unit tests and model notes#3832Vantomas wants to merge 2 commits into
Vantomas wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Add model unit tests and model notes for the
tplinkmodel, validated against a TP-Link DeltaStream DS-P7001-08 GPON OLT (software1.0.0), plus a smallpre_logoutfix.Changes
pre_logout: Send\r\ninpre_logout. This is what lets the captured simulation match the model in the unit test.spec/model/data/tplink#...): simulation, expected output, prompt and secret fixtures for the DeltaStream DS-P7001-08.docs/Model-Notes/TPLink.md):auth_methods: ["none", "password"].Note on the simulation file: it starts at the privileged
#prompt with theenablestep commented out (explained in a header comment in the file).