Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LRS implementations should be able to perform compare-and-swap document operations using ETags.
This PR takes the work in #106 and extends it to all applicable document actions, and additionally adds normalized preconditions to the pedestal context for the impl to use.
Note that this does NOT disable the existing precondition checks used by the memory LRS and though these do not interfere with implementations doing it themselves it is extra work. A further needed improvement is to allow implementations to signal to the lib that they are capable of CAS and do not need the interceptors turned on.This is now implemented, and SQL LRS is using successfully