More available arguments for ycmcompleter-subcommands#4105
Closed
Shuangcheng-Ni wants to merge 2 commits intoycm-core:masterfrom
Closed
More available arguments for ycmcompleter-subcommands#4105Shuangcheng-Ni wants to merge 2 commits intoycm-core:masterfrom
Shuangcheng-Ni wants to merge 2 commits intoycm-core:masterfrom
Conversation
This change provides more available arguments for commands like `YcmCompleter`. The new available arguments `--line_num=` and `--column_num=` enables the commands to be executed at any position. Without these two arguments, the commands can only be executed at cursor position.
Member
|
Thanks for making a PR! Whats the practical use case for this? can you add tests? And docs? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4105 +/- ##
==========================================
- Coverage 86.41% 86.31% -0.11%
==========================================
Files 33 33
Lines 4358 4361 +3
==========================================
- Hits 3766 3764 -2
- Misses 592 597 +5 |
4 tasks
Author
Thanks for your quick reply! You may take a look at my latest PR. I'm going to use commands like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
This change provides more available arguments for commands like
YcmCompleter. The new available arguments--line_num=and--column_num=enables the commands to be executed at any position. Without these two arguments, the commands can only be executed at cursor position.The result of the command

YcmCompleter GetDoc --line_num=6 --column_num=2:This change is