Skip to content

Feat/add label and error text UI component - #496

Open
TerSV86 wants to merge 5 commits into
developfrom
feat/add-label-and-errorText-ui-component
Open

Feat/add label and error text UI component#496
TerSV86 wants to merge 5 commits into
developfrom
feat/add-label-and-errorText-ui-component

Conversation

@TerSV86

@TerSV86 TerSV86 commented Oct 13, 2024

Copy link
Copy Markdown

Вынес label и errorText в отдельные UI компоненты
#469

@TerSV86 TerSV86 linked an issue Oct 13, 2024 that may be closed by this pull request
5 tasks

@INextYP INextYP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Исправь конфликты и комментарии
  • Проверь по всем страницам, что ничего не сломалось

Comment thread src/shared/ui/errorText/errorText.module.css Outdated
Comment thread src/shared/ui/errorText/index.tsx Outdated
Comment thread src/shared/ui/input-phone/index.tsx Outdated
…ил типизацию props компонента ErrorText, исключил условный рендеринг в inpur-phone
@TerSV86
TerSV86 requested a review from INextYP October 22, 2024 16:27

@INextYP INextYP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё пару исправлений

Comment thread src/shared/ui/label/index.tsx Outdated
Comment thread src/shared/ui/label/label.module.css Outdated
@TerSV86
TerSV86 requested a review from INextYP October 23, 2024 15:05
@INextYP

INextYP commented Oct 30, 2024

Copy link
Copy Markdown
Collaborator

Задача выполнена. PR будет вмёржен после внедрения Typography компонента

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Вынести label и errorText в отдельные UI компоненты

2 participants