Switch REST library from served to Crow#43
Open
ClemensElflein wants to merge 2 commits intofeature/spdlog-loggingfrom
Open
Switch REST library from served to Crow#43ClemensElflein wants to merge 2 commits intofeature/spdlog-loggingfrom
ClemensElflein wants to merge 2 commits intofeature/spdlog-loggingfrom
Conversation
Collaborator
|
I think this is mixed with other changes (like those from switching logging to sdplog). The relevant changes are in Edit: I think you have gotten rid of the only git submodule, so the |
ClemensElflein
changed the base branch from
master
to
feature/spdlog-logging
Member
Author
|
Yes, this builds on the other PR so that we don't have conflicts. I have now changed the base branch, so the changelog in github only shows the relevant changes. Yes, true. That's not necessary any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since served development was halted (https://github.com/meltwater/served) and the CORS requests were broken for newer browsers, I decided to swap to Crow (https://crowcpp.org/master/) as REST library in this PR.