Add software serial based logging (implements #33)#34
Open
maehw wants to merge 4 commits intoxtech:masterfrom
Open
Add software serial based logging (implements #33)#34maehw wants to merge 4 commits intoxtech:masterfrom
maehw wants to merge 4 commits intoxtech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Loggingbased on base classPrintand thereforeLogging::println().NeoSWSerialas other software serial impementations are not known to be compatible with the already usedPinChangeInterruptlibrary. Make sure to#define NEOSWSERIAL_EXTERNAL_PCINT // uncomment to use your own PCINT ISRsinside ofNeoSWSerial.h.#define LOGGING_ACTIVEinside ofLogging.h(also not requiring to resolve theNeoSWSerialdependency). Probably should be the default as it currently is in the state of this pull request.Side effects:
F("mystring")macro, puts it inPROGMEMtherefore not taking away "expensive" SRAM. Seems to be an appropriate solution.(Edit: see also https://www.arduino.cc/reference/en/language/variables/utilities/progmem/)
SelfomatControllerfirmware, e.g. when triggering the flash or playing animations on the NeoPixel ring. This would require some testing with the xtech hardware which I don't have available.Please note that the code also isn't fully tested yet on my side - but at least provides a proof-of-concept (PoC).