Fix device watch errors and race-conditions#901
Merged
hpccc53 merged 9 commits intoxremap:masterfrom Apr 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device watching had some problems with both race-condititions and sensitivity to the expectable unpredictable batching and duplicate file events.
The important commits:
/dev/inputfolder, anything can happen in the time untildevice.grab()is called. The only solution is therefore to squashENODEVerrors when grabbing. Note thatInputDevice::try_from()already squashes all errors.Problems that still remain
evdevprints an error message, if the device can't be ungrabbed, even though the device is gone, and ungrab is not needed. I have made a PR that is still open.The error message is "Failed to ungrab device: No such device (os error 19)"