Skip to content

Feat: enhance download progress details - #5310

Merged
qinxuye merged 6 commits into
xorbitsai:mainfrom
Minamiyama:feat/enhance-download-progress-details
Aug 14, 2026
Merged

Feat: enhance download progress details#5310
qinxuye merged 6 commits into
xorbitsai:mainfrom
Minamiyama:feat/enhance-download-progress-details

Conversation

@Minamiyama

Copy link
Copy Markdown
Collaborator

This PR adds detailed model download progress to the launch dialog, allowing users to view each file’s progress, status, download speed, and estimated remaining time while a model is being downloaded.

80b44156d17bba6c495cfb9860d7ad83

@XprobeBot XprobeBot added this to the v3.x milestone Aug 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces detailed download progress tracking when launching models, adding a new frontend component to display per-file progress, speed, and ETA, alongside backend updates to collect and expose these metrics. A high-severity issue was identified in the progress calculation logic where a null progress value prematurely evaluates to zero, bypassing the fallback calculation; a code suggestion has been provided to fix this.

Comment thread xinference/model/utils.py

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
qinxuye merged commit 8f88137 into xorbitsai:main Aug 14, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants