Skip to content

feat: add XEN-L006 (xod/uart additions) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabbapeople wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add XEN-L006 (xod/uart additions) #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a20e732
feat: add XEN-L005 (xod/core additions)
gabbapeople Sep 13, 2018
07cb7d6
feat: add XEN-L006 (xod/uart additions)
gabbapeople Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions XEN-L006/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# XEN-L006: Nodes addition

The `xod/uart` library has the `print` node. This node "Writes a string bytes per byte into UART.". Also `print` writes bytes for the `\r`, `\n` escape sequences. Obviously the `read` node should be added to the `xod/uart` library.

On a pulse or true/false bool state, the `read` node should output accumulated string or a group of strings from a UART byte stream.

## List of nodes

### accumulate-line
Copy link
Copy Markdown
Contributor

@brusherru brusherru Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... we have such node in xod/stream.
And also it has very important input CAP (capacity), which is skipped here.

Maybe better to do a handy node accumulate-line in xod/stream library, which will be a composition of nodes accumulate-string and pass-until?


Utility?
The target library is under consideration

Accumulates a string from a stream of characters by appending each new character to the end of the string until the end of the line escape sequence if found. Drops the carriage return escape sequence if it is found

- [in] CHAR :: Byte - A new character to be pushed to the end of the string line
- [in] PUSH :: Pulse - Push new character
- [in] RST :: Pulse - Empty the accumulated string line and start over

- [out] LINE :: String - Accumulated line
- [out] LINE :: Pulse - Fires on a new accumulated line
Copy link
Copy Markdown

@evgenykochetkov evgenykochetkov Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two pins can't have the same label. Did you mean something like UPD?


### read

`xod/uart`

Streams string lines from UART

- [in] UART :: uart - An UART object
- [in] READ :: Pulse - Triggers read of a string line ???
- [in] READ :: Bool - The true value turns on the stream of the string lines ???

- [out] LINE :: String - String line that is read ???
Copy link
Copy Markdown
Contributor

@brusherru brusherru Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue with capacity 🤔

- [OUT] UPD :: Pulse - Fires if a new line is read ???