Skip to content

Update github action - #680

Closed
neekolas wants to merge 5 commits into
mainfrom
07-01-update_github_action
Closed

neekolas wants to merge 5 commits into
mainfrom
07-01-update_github_action

Conversation

@neekolas

@neekolas neekolas commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

TL;DR

Added support for customizable PR titles and descriptions in the documentation update workflow.

What changed?

  • Added a new "Output Requirements" section to the documentation analysis prompt that explains how to customize PR titles and descriptions
  • Added logic to check for and use custom PR content from claude_pr_title.txt and claude_pr_body.txt files
  • Added branch cleanup to delete existing branches before creating new ones
  • Removed hardcoded PR labels from the PR creation command

How to test?

  1. Create a documentation update workflow run
  2. Have Claude generate files named claude_pr_title.txt and claude_pr_body.txt in the docs-repo directory
  3. Verify that the PR uses the custom title and body from these files
  4. Test the branch cleanup functionality by running the workflow against an existing branch

Why make this change?

This change gives Claude more control over the PR creation process, allowing it to craft more specific and contextual PR titles and descriptions based on the actual documentation changes it's making. The branch cleanup functionality also prevents errors when running the workflow multiple times against the same release.

@changeset-bot

changeset-bot Bot commented Jul 2, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: dcd8bae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@neekolas
neekolas force-pushed the 07-01-update_github_action branch from 8366ed3 to 56511af Compare July 2, 2025 00:52

neekolas commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@macroscopeapp

macroscopeapp Bot commented Jul 2, 2025

Copy link
Copy Markdown

Revert XMTP SDK from development version 4.4.0-dev to stable version 4.2.x and remove stream closure callback parameters from all streaming methods

This pull request reverts the XMTP React Native SDK from development version 4.4.0-dev back to stable version 4.2.x across all platforms and removes stream closure callback functionality from the API. The changes affect multiple core components:

📍Where to Start

Start with the version changes in package.json to understand the scope of the version rollback, then review the API changes in src/lib/Client.ts to see the removed configuration options and their impact on the client creation methods.


Macroscope summarized dcd8bae.

@neekolas
neekolas force-pushed the 07-01-update_github_action branch from 56511af to 5f2309c Compare July 2, 2025 00:55
@neekolas
neekolas marked this pull request as ready for review July 2, 2025 00:55
@neekolas
neekolas requested a review from a team as a code owner July 2, 2025 00:55
@jhaaaa
jhaaaa requested a review from a team as a code owner August 5, 2025 17:46
@jhaaaa

jhaaaa commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Oh. My. God. It started so innocently, asking gemini-2.5-pro-preview-06-05 in Cursor to help me remove my two commits from this PR, and now it includes changes to 30 files that weren't in the original PR. I'm going to have to close this PR and open a fresh one with only the original updates in it.

@jhaaaa jhaaaa mentioned this pull request Aug 5, 2025
@jhaaaa

jhaaaa commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Closing. Recreated here #699.

@jhaaaa jhaaaa closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants