Repository navigation
Feat(engine): make Start/Stop return error instead of log.Fatalf (#550) - #552
Merged
Merged
Conversation
Contributor
Author
|
@xjasonlyu 麻烦看看。 |
Contributor
Author
|
@xjasonlyu 可以合并这个 PR 吗 😀 |
There was a problem hiding this comment.
🟡 Changes recommended
main.go currently calls log.Fatalf inside a deferred cleanup, which can skip other deferred cleanups due to os.Exit semantics.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Contributor
Author
|
这个AI的review结果似乎不成立：
|
Keep Start/Stop returning errors for library callers, and move the exit-on-failure behavior into the OrFatal variants used by main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
|
已合并。 |
max-did-it
pushed a commit
to glitch-vpn/tun2socks
that referenced
this pull request
Oct 26, 2026
* Feat(engine): make Start/Stop return error instead of log.Fatalf (xjasonlyu#550) * Refactor(engine): add StartOrFatal/StopOrFatal wrappers --------- Co-authored-by: Jason Lyu <xjasonlyu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #550