Create App Store build without offers#806
Open
Rigidity wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
@BugBot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
2 issues from previous reviews remain unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit fd6f936. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Wide UI surface area and two iOS release artifacts increase the chance of inconsistent builds or missed entry points (routes still exist in
App.tsx); wallet offer logic in Rust is unchanged aside from formatting.Overview
Adds build-time feature toggles (
VITE_DISABLE_OFFERS,VITE_DISABLE_OPTIONS,VITE_DISABLE_SWAP) viasrc/lib/features.ts, replacing hard-coded iOS checks so the same binary shape can hide Offers, Options, and Swap when env vars are set at build time.The CI iOS matrix now produces two App Store Connect builds: TestFlight (all features on, build number 1) and App Store (offers/options/swap disabled, build number 2). iOS steps use
platform_type: iOS, pass theVITE_*flags into the signed build, copy each IPA to a distinctartifacts/ios/name, and upload/release from those paths.Across the app, offer-related UI (nav, “add to offer”, Dexie/local offer sections, QR offer routing, default offer expiry, resync/migration copy) is gated on
offersEnabled; options nav and option picker in offers useoptionsEnabled; swap nav usesswapEnabled. Copy for locked coins and confirmations no longer mentions offers when disabled.Reviewed by Cursor Bugbot for commit fd6f936. Bugbot is set up for automated code reviews on this repo. Configure here.