Skip to content

Create App Store build without offers#806

Open
Rigidity wants to merge 4 commits into
mainfrom
offer-feature-flag
Open

Create App Store build without offers#806
Rigidity wants to merge 4 commits into
mainfrom
offer-feature-flag

Conversation

@Rigidity

@Rigidity Rigidity commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Wide UI surface area and two iOS release artifacts increase the chance of inconsistent builds or missed entry points (routes still exist in App.tsx); wallet offer logic in Rust is unchanged aside from formatting.

Overview
Adds build-time feature toggles (VITE_DISABLE_OFFERS, VITE_DISABLE_OPTIONS, VITE_DISABLE_SWAP) via src/lib/features.ts, replacing hard-coded iOS checks so the same binary shape can hide Offers, Options, and Swap when env vars are set at build time.

The CI iOS matrix now produces two App Store Connect builds: TestFlight (all features on, build number 1) and App Store (offers/options/swap disabled, build number 2). iOS steps use platform_type: iOS, pass the VITE_* flags into the signed build, copy each IPA to a distinct artifacts/ios/ name, and upload/release from those paths.

Across the app, offer-related UI (nav, “add to offer”, Dexie/local offer sections, QR offer routing, default offer expiry, resync/migration copy) is gated on offersEnabled; options nav and option picker in offers use optionsEnabled; swap nav uses swapEnabled. Copy for locked coins and confirmations no longer mentions offers when disabled.

Reviewed by Cursor Bugbot for commit fd6f936. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/components/Nav.tsx
Comment thread .github/workflows/build.yml Outdated
@Rigidity Rigidity changed the title Split iOS build into hotdog and not hotdog Create App Store build without offers Jul 12, 2026
Comment thread src/components/Nav.tsx
Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml
@Rigidity

Copy link
Copy Markdown
Collaborator Author

@BugBot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

2 issues from previous reviews remain unresolved.

Fix All in Cursor

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fd6f936. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant