Optimize comparison operators#94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes core compiler lowering for ordering operators used throughout Rue programs; behavior should be equivalent but CLVM shape and costs differ, so regression risk is in edge cases for int/bytes compares.
Overview
>=/<=(int and bytes) inlower.rsno longer lower toany(>, =); they now usenot(<)ornot(>), cutting extraEq/Anynodes from generated CLVM while keeping the same semantics.Environment::treesorts symbols by reference count withsort_by_key(|b| Reverse(b.1))instead of a manualsort_byon counts.The release bumps workspace crates 0.8.4 → 0.8.5, adds
rust-toolchain.toml(Rust 1.97.0), expandscomparisonassertions inoperators.rue, and refreshesoperators.yamlprogram/cost snapshots.Reviewed by Cursor Bugbot for commit 6e80f9f. Bugbot is set up for automated code reviews on this repo. Configure here.