Use palloc0() instead of palloc0fast() - #108
Open
jeltz wants to merge 1 commit into
Open
Conversation
The palloc0fast() function was removed in PostgreSQL 17 since it according to the PostgreSQL developers was not actually faster than palloc0() on modern compilers. So to support PostgreSQL 17 and later we should switch to using palloc0(). See https://git.postgresql.org/pg/commitdiff/3c080fb4fad3e1c1e34f74a7b84a443137adc9f2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
palloc0fast()function was removed in PostgreSQL 17 since it according to the PostgreSQL developers was not actually faster thanpalloc0()on modern compilers. So to support PostgreSQL 17 and later we should switch to usingpalloc0().See https://git.postgresql.org/pg/commitdiff/3c080fb4fad3e1c1e34f74a7b84a443137adc9f2