Skip to content

fix: avoid unnecessary brpc recompilation. #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kang-Meng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid unnecessary brpc recompilation. #2232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions third_party/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,54 @@ include(cc_library)

add_subdirectory(sentencepiece)
add_subdirectory(minja)

set(_XLLM_BRPC_GIT_DIR_WAS_SET FALSE)
set(_XLLM_BRPC_GIT_WORK_TREE_WAS_SET FALSE)
if(DEFINED ENV{GIT_DIR})
set(_XLLM_BRPC_GIT_DIR_WAS_SET TRUE)
set(_XLLM_BRPC_SAVED_GIT_DIR "$ENV{GIT_DIR}")
endif()
if(DEFINED ENV{GIT_WORK_TREE})
set(_XLLM_BRPC_GIT_WORK_TREE_WAS_SET TRUE)
set(_XLLM_BRPC_SAVED_GIT_WORK_TREE "$ENV{GIT_WORK_TREE}")
endif()

set(_XLLM_BRPC_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/brpc")
set(_XLLM_BRPC_GIT_DIR "")
set(_XLLM_BRPC_GIT_RESULT 1)
unset(ENV{GIT_DIR})
unset(ENV{GIT_WORK_TREE})
if(EXISTS "${_XLLM_BRPC_SOURCE_DIR}/.git")
execute_process(
COMMAND git -C "${_XLLM_BRPC_SOURCE_DIR}" rev-parse --absolute-git-dir
OUTPUT_VARIABLE _XLLM_BRPC_GIT_DIR
OUTPUT_STRIP_TRAILING_WHITESPACE
RESULT_VARIABLE _XLLM_BRPC_GIT_RESULT
ERROR_QUIET
)
endif()

if(_XLLM_BRPC_GIT_RESULT EQUAL 0 AND _XLLM_BRPC_GIT_DIR)
set(ENV{GIT_DIR} "${_XLLM_BRPC_GIT_DIR}")
set(ENV{GIT_WORK_TREE} "${_XLLM_BRPC_SOURCE_DIR}")
else()
set(ENV{GIT_DIR} "${CMAKE_CURRENT_BINARY_DIR}/brpc-no-git")
unset(ENV{GIT_WORK_TREE})
endif()

add_subdirectory(brpc)

if(_XLLM_BRPC_GIT_DIR_WAS_SET)
set(ENV{GIT_DIR} "${_XLLM_BRPC_SAVED_GIT_DIR}")
else()
unset(ENV{GIT_DIR})
endif()
if(_XLLM_BRPC_GIT_WORK_TREE_WAS_SET)
set(ENV{GIT_WORK_TREE} "${_XLLM_BRPC_SAVED_GIT_WORK_TREE}")
else()
unset(ENV{GIT_WORK_TREE})
endif()

add_subdirectory(smhasher/src)
add_subdirectory(cpprestsdk)
if(USE_MUSA AND TARGET cpprest)
Expand Down