Skip to content

chem: add scalar guards for p_hcl and p_ch3cl in add_anthropogenics t… #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlphaBetaGammaChi wants to merge 3 commits into
base: release-v4.8.1
Choose a base branch
from
+4 −5
Open

chem: add scalar guards for p_hcl and p_ch3cl in add_anthropogenics t… #2387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c4c963
chem: add scalar guards for p_hcl and p_ch3cl in add_anthropogenics t…
AlphaBetaGammaChi Aug 28, 2026
143f6dc
chem: restore safe area=dx*dx in emissions_driver to prevent SIGSEGV …
AlphaBetaGammaChi Aug 30, 2026
a7eb3d5
Uncomment area calculation in emissions_driver.F
AlphaBetaGammaChi Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions chem/emissions_driver.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,8 @@ subroutine emissions_driver(id,ktau,dtstep,DX,DY, &

ivolcano=0

!area=dx*dx
! A. Ukhov 12 Oct 2024
area=(dx/mapfac_mx(i,j))*(dy/mapfac_my(i,j))

area=dx*dx

dust_emiss_active = 0
seasalt_emiss_active = 0
Expand Down
4 changes: 2 additions & 2 deletions chem/module_emissions_anthropogenics.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ subroutine add_anthropogenics(id,dtstep,dz8w,config_flags,rho_phy,alt, &
chem(its:ite,k,j,p_no) = chem(its:ite,k,j,p_no) + emis_ant(its:ite,k,j,p_e_no)*conv_rho(its:ite)
chem(its:ite,k,j,p_no2) = chem(its:ite,k,j,p_no2) + emis_ant(its:ite,k,j,p_e_no2)*conv_rho(its:ite)
chem(its:ite,k,j,p_nh3) = chem(its:ite,k,j,p_nh3) + emis_ant(its:ite,k,j,p_e_nh3)*conv_rho(its:ite)
chem(its:ite,k,j,p_hcl) = chem(its:ite,k,j,p_hcl) + emis_ant(its:ite,k,j,p_e_hcl)*conv_rho(its:ite)
chem(its:ite,k,j,p_ch3cl) = chem(its:ite,k,j,p_ch3cl) + emis_ant(its:ite,k,j,p_e_ch3cl)*conv_rho(its:ite)
if (p_e_hcl >= param_first_scalar .and. p_hcl >= param_first_scalar) chem(its:ite,k,j,p_hcl) = chem(its:ite,k,j,p_hcl) + emis_ant(its:ite,k,j,p_e_hcl)*conv_rho(its:ite)
if (p_e_ch3cl >= param_first_scalar .and. p_ch3cl >= param_first_scalar) chem(its:ite,k,j,p_ch3cl) = chem(its:ite,k,j,p_ch3cl) + emis_ant(its:ite,k,j,p_e_ch3cl)*conv_rho(its:ite)
is_mozart:if( is_moz_chm ) then
chem(its:ite,k,j,p_bigalk) = chem(its:ite,k,j,p_bigalk) + emis_ant(its:ite,k,j,p_e_bigalk)*conv_rho(its:ite)
chem(its:ite,k,j,p_bigene) = chem(its:ite,k,j,p_bigene) + emis_ant(its:ite,k,j,p_e_bigene)*conv_rho(its:ite)
Expand Down