Bug fix in WDM7

[Songyou184]

TYPE: Bug fix

KEYWORDS: WDM7, Sedimentation, Hail

SOURCE: Songyou Hong

DESCRIPTION OF CHANGES:
Problem:
Sedimentation of raindrop in WDM7 does not check the mass conservation.
Dry growth of hail needs to be updated.

Solution:
Sedimentation of rain checks the mass conservation.
Dry growth of hail waits for the wet growth of hail.

LIST OF MODIFIED FILES:
M phys/module_mp_wdm7.F

TESTS CONDUCTED:

1. It was tested for 2d-squall2d and results are physically robust.
2. The Jenkins tests are all passing.

RELEASE NOTE: This PR fixes sedimentation calculation and hail physics in WDM7 microphysics.

[weiwangncar]

Regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

[dudhia]

This should be targeted for develop unless we have a 4.8.1 branch now.

[dudhia]

is this the final change in WDM7?

[Songyou184]

yes. it is the final...

…

On Tue, Aug 4, 2026 at 1:23 PM dudhia ***@***.***> wrote: ***@***.**** approved this pull request. is this the final change in WDM7? — Reply to this email directly, view it on GitHub <#2366?email_source=notifications&email_token=AVR3U6UPGT66RSHUNSYA6FT5IIZ3LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBVHAYTMMJSHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4858161299>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR3U6WCSRR63OOISNBPJMT5IIZ3LAVCNFSNUABEKJSXA33TNF2G64TZHM3DKOBVGIYDMOJ3JFZXG5LFHM2DQNZYGI4TCMBXGKQXMAQ> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AVR3U6VL3LXK6IYLQ7CEMVD5IIZ3LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBVHAYTMMJSHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/AVR3U6QT7M5AA4D7H2YIZ5T5IIZ3LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBVHAYTMMJSHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you authored the thread.Message ID: ***@***.***>