Skip to content

Bug fix in UDM MP #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Songyou184 wants to merge 2 commits into
base: release-v4.8.1
Choose a base branch
from
+5 −10
Open

Bug fix in UDM MP #2365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23cf546
modified: module_mp_udm.F
Songyou184 Jul 13, 2026
afc861b
Update module_mp_udm.F to trigger a test
weiwangncar Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions phys/module_mp_udm.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
!! author Songyou Hong [hong@ucar.edu, songyouhong@gmail.com]
!!
module module_mp_udm
use module_mp_radar
use module_gfs_machine , only : kind_phys
use module_mp_radar
use module_gfs_machine , only : kind_phys
!
!-------------------------------------------------------------------------------
! parameters for microphysical processes
Expand Down Expand Up @@ -2533,7 +2533,7 @@ subroutine udm2d(t1, q1 &
!
do n = 1, niter
do k = ktop, kts, -1
if(qrs(k,i,1)>qrmin) then
if(qrs(k,i,1)>0.) then
denqr(k) = dend(k,i)*qrs(k,i,1)
denqn(k) = dend(k,i)*ncr(k,i,3)
else
Expand All @@ -2549,13 +2549,8 @@ subroutine udm2d(t1, q1 &
call semi_lagrangian(1,kdim,max(ktop,2),dend(:,i),denfac(:,i),t(:,i), &
delz(:,i),vtn(:),denqn(:),qnpath,dtcfl,lat,i)
do k = ktop, kts, -1
if(denqr(k)>qrmin) then
qrs(k,i,1) = max(denqr(k)/dend(k,i),0.)
ncr(k,i,3) = max(denqn(k)/dend(k,i),0.)
else
qrs(k,i,1) = 0.0
ncr(k,i,3) = 0.0
endif
qrs(k,i,1) = max(denqr(k)/dend(k,i),0.)
ncr(k,i,3) = max(denqn(k)/dend(k,i),0.)
enddo
!
precip_r = qrpath/dtcld + precip_r ! [kgm-2s-1]
Expand Down