Skip to content

CFBM: Refinements in the level set - #2361

Open
pedro-jm wants to merge 2 commits into
wrf-model:release-v4.8.1from
pedro-jm:cfbm_fix
Open

CFBM: Refinements in the level set#2361
pedro-jm wants to merge 2 commits into
wrf-model:release-v4.8.1from
pedro-jm:cfbm_fix

Conversation

@pedro-jm

Copy link
Copy Markdown
Contributor

TYPE: bug fix

KEYWORDS: CFBM, fire propagation, default settings

SOURCE: Pedro A. Jimenez (NCAR)

DESCRIPTION OF CHANGES:
Problem:
There are instabilities in the methods used to determine the fire propagation

Solution:

  1. We updated the default value of a namelist variable, the pseudo time step coefficient for the level set reinitialization
  2. We use the previous ENO method to solve the level set equation

ISSUE: N/A

LIST OF MODIFIED FILES: We only updated the hash of the fire_behavior git submodule

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Refined methods for the fire propagation in the CFBM

@pedro-jm
pedro-jm requested a review from a team as a code owner June 29, 2026 22:20
@weiwangncar
weiwangncar changed the base branch from develop to release-v4.8.1 July 27, 2026 19:43
@dudhia

dudhia commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

This PR seems to have failed the tests. @weiwangncar can you check?

@weiwangncar

Copy link
Copy Markdown
Collaborator

@dudhia I did not receive any test results. I started a re-test and see if it goes anywhere.

@weiwangncar

Copy link
Copy Markdown
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants