Repository navigation
Extract result bug - #815
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the custom extraction functionality where duplicate results from multiple input columns were not being properly deduplicated. The fix ensures that when the same value is extracted from multiple input columns, it only appears once in the final output.
Key Changes:
- Modified the result concatenation logic to remove duplicate extracted values using
dict.fromkeys() - Added test coverage to verify deduplication works correctly with multiple input columns containing the same match
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| wrangles/recipe_wrangles/extract.py | Updated concatenation logic to deduplicate extracted results from multiple columns |
| tests/recipes/wrangles/test_extract.py | Added test case verifying deduplication of matches across multiple input columns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thomasstvr
requested review from
ChrisWRWX and
cerdamario13
and removed request for
ChrisWRWX
October 27, 2025 16:08
cerdamario13
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.