Repository navigation
Train extract v3 - #810
Merged
Merged
Train extract v3#810
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces support for a new extract/write header version (pattern 3.0) by changing the default header from "Output (Optional)" to "Output" and adding corresponding test coverage.
- Updates header check in extract to use ['Find', 'Output', 'Notes']
- Adds new version entry 'pattern 3.0' in connectors
- Adds tests for versions 1.0, 2.0, and new 3.0 (but lacks a regression test for legacy header handling in updated extract logic)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wrangles/train.py | Changes header validation to require ['Find', 'Output', 'Notes'] |
| wrangles/connectors/train.py | Adds version mapping for new pattern 3.0 header |
| tests/connectors/test_train.py | Adds tests for write operations including new 3.0 format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…-extract-pattern-columns' into Train-Extract-v3
mborodii-prog
self-requested a review
January 19, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.