Skip to content

fix: pem.test exit 1 on test failure #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkAtwood wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

fix: pem.test exit 1 on test failure #10250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/pem.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,3 +457,7 @@ fi
# Cleanup temporaries
do_cleanup

if [ "$TEST_FAIL_CNT" != "0" ]; then
exit 1
fi
Comment on lines +460 to +462
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!= "0" performs a string comparison; since TEST_FAIL_CNT is a numeric counter, it’s more robust/idiomatic to use a numeric test (e.g., -ne 0). If TEST_FAIL_CNT can ever be empty/unset, consider defaulting it (e.g., ${TEST_FAIL_CNT:-0}) before the comparison to avoid test errors in stricter shells.

Copilot uses AI. Check for mistakes.

Loading