Skip to content

Use upload-pages-artifact action again#101

Merged
delucis merged 4 commits intomainfrom
chris/upload-artifact
Mar 31, 2026
Merged

Use upload-pages-artifact action again#101
delucis merged 4 commits intomainfrom
chris/upload-artifact

Conversation

@delucis
Copy link
Copy Markdown
Member

@delucis delucis commented Mar 31, 2026

In #88 we switched from https://github.com/actions/upload-pages-artifact to owning the code for uploading an artifact ourselves because v4 of that action had stopped including dotfiles (used for e.g. .well-known/)

actions/upload-pages-artifact#137 just added back the ability to include hidden files, so we can now switch back and avoid having to own all that extra code.

Copy link
Copy Markdown
Contributor

@ollecoffee ollecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find, kinda weird to tag main tho :D

@delucis
Copy link
Copy Markdown
Member Author

delucis commented Mar 31, 2026

kinda weird to tag main tho

Yeah, I asked in the PR. I assume they’ll tag a release eventually. Doesn’t matter too much though as we always pin to a commit anyway, so the only difference is that this commit is not a tagged version number.

@delucis delucis merged commit 4470635 into main Mar 31, 2026
@delucis delucis deleted the chris/upload-artifact branch March 31, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants