refactor: improve a11y for proteus ID in settings [WPB-22420]#21210
Open
markbrockhoff wants to merge 1 commit intodevfrom
Open
refactor: improve a11y for proteus ID in settings [WPB-22420]#21210markbrockhoff wants to merge 1 commit intodevfrom
markbrockhoff wants to merge 1 commit intodevfrom
Conversation
markbrockhoff
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
screendriver
previously approved these changes
May 4, 2026
markbrockhoff
force-pushed
the
mb/improve-a11y-for-proteus-id-in-settings
branch
from
3252706 to
37ad70b
Compare
So far the label was just a paragraph above the actual value, this links them using aria attributes and improves the locator used within e2e tests by that.
markbrockhoff
force-pushed
the
mb/improve-a11y-for-proteus-id-in-settings
branch
from
37ad70b to
acbe441
Compare
|
zskhan
approved these changes
May 4, 2026
screendriver
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the label was just a paragraph above the actual value, this links them using aria attributes and improves the locator used within e2e tests by that.