Skip to content

test: add regression test for favorites folder [WPB-25073]#21186

Merged
JacquelineLehner merged 4 commits intodevfrom
WPB-19518-write-missing-test-for-folders
May 4, 2026
Merged

test: add regression test for favorites folder [WPB-25073]#21186
JacquelineLehner merged 4 commits intodevfrom
WPB-19518-write-missing-test-for-folders

Conversation

@JacquelineLehner
Copy link
Copy Markdown
Collaborator

@JacquelineLehner JacquelineLehner commented Apr 30, 2026

TaskWPB-25073 [Web][QA] Write TC-742 test for Folders

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The regression test suite was missing a test for the folder flow, specifically TC-742: I want to see 1:1 and group conversations in Favorites folder.

Solutions

This PR implements the missing automated test for TC-742.

It verifies the functionality and behavior of the Favorites folder. The implemented scenarios ensure:

  • Both 1:1 and group conversations can be added to the Favorites folder.
  • Unread message notification badges appear correctly on the Favorites sidebar button for both direct and group messages.
  • A group conversation remains visible in the Favorites folder even after the user is removed from the group.
  • Removing conversations from Favorites successfully empties the folder, while the conversations remain visible in the "All" view.

To support these assertions, the following Page Object Models were updated:

  • conversationList.page.ts: Added addToFavoritesButton to the context menu.
  • conversationSidebar.component.ts: Added favoritesButton locator.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 338
  • Failed: 0
  • Skipped: 10
  • 🔁 Flaky: 8
  • 📊 Total: 356
  • Total Runtime: 495.0s (~ 8 min 15 sec)
specs/AccountSettings/accountSettings.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ account settings > I want to see the Full Name wherever my name gets displayed (tags: TC-1948, regression)
specs/Block/block.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Block: User A and User B are NOT in the same team > Verify you still receive messages from blocked person in a group chat (tags: TC-141, regression)
specs/Calling/calling.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Calling > I want to see the full call participant list (tags: TC-2844, regression)
specs/ClearConversationContent/clearConversationContent.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Clear Conversation Content > I want to clear content of 1:1 conversation via conversation list (tags: TC-154, regression)
specs/Connections/Connections.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Connections > Verify sending a connection request to user from conversation view (tags: TC-369, regression)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/Drive/drive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Conversations > Edit multipart message in a group conversation (tags: crit-flow-cells, regression, TC-8786)
specs/ParticipantProfile/participantProfile.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Participant Profile > I want to see the group admin icon as a member seeing the group admin profile (tags: TC-1485, regression)

markbrockhoff
markbrockhoff previously approved these changes Apr 30, 2026
@JacquelineLehner JacquelineLehner changed the title test: add regression test for favorites folder [WPB-25037] test: add regression test for favorites folder [WPB-25073] Apr 30, 2026
@JacquelineLehner JacquelineLehner force-pushed the WPB-19518-write-missing-test-for-folders branch from 2b29b33 to 32b3d79 Compare April 30, 2026 12:13
This commit introduces a new test case to the Folders suite to verify
the functionality and behavior of the Favorites folder.

Implemented scenarios include:
- Adding both 1:1 and group conversations to the Favorites folder.
- Verifying that unread message notifications badge appear correctly
  on the Favorites sidebar button for both direct and group messages.
- Ensuring a group conversation remains visible in the Favorites folder
  even after the user is removed from the group.
- Removing conversations from Favorites and verifying the folder
  becomes empty while conversations remain in the "All" view.

To support these assertions, the following Page Object Models were updated:
- `conversationList.page.ts`: Added `addToFavoritesButton` to the context menu.
- `conversationSidebar.component.ts`: Added `favoritesButton` locator.

Refs: WPB-25073

# Conflicts:
#	apps/webapp/test/e2e_tests/specs/Folders/folders.spec.ts
…Sidebar.component.ts from getByTestId to getByRole

Refs: WPB-25073
@JacquelineLehner JacquelineLehner force-pushed the WPB-19518-write-missing-test-for-folders branch from 462aa32 to 041e425 Compare May 4, 2026 07:34
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
8.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@JacquelineLehner JacquelineLehner added this pull request to the merge queue May 4, 2026
Merged via the queue into dev with commit 7209e9b May 4, 2026
293 of 300 checks passed
@JacquelineLehner JacquelineLehner deleted the WPB-19518-write-missing-test-for-folders branch May 4, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants