test: add regression test for favorites folder [WPB-25073]#21186
Merged
JacquelineLehner merged 4 commits intodevfrom May 4, 2026
Merged
test: add regression test for favorites folder [WPB-25073]#21186JacquelineLehner merged 4 commits intodevfrom
JacquelineLehner merged 4 commits intodevfrom
Conversation
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/AccountSettings/accountSettings.spec.ts (❌ 0 failed,
|
markbrockhoff
previously approved these changes
Apr 30, 2026
2b29b33 to
32b3d79
Compare
zskhan
reviewed
Apr 30, 2026
This commit introduces a new test case to the Folders suite to verify the functionality and behavior of the Favorites folder. Implemented scenarios include: - Adding both 1:1 and group conversations to the Favorites folder. - Verifying that unread message notifications badge appear correctly on the Favorites sidebar button for both direct and group messages. - Ensuring a group conversation remains visible in the Favorites folder even after the user is removed from the group. - Removing conversations from Favorites and verifying the folder becomes empty while conversations remain in the "All" view. To support these assertions, the following Page Object Models were updated: - `conversationList.page.ts`: Added `addToFavoritesButton` to the context menu. - `conversationSidebar.component.ts`: Added `favoritesButton` locator. Refs: WPB-25073 # Conflicts: # apps/webapp/test/e2e_tests/specs/Folders/folders.spec.ts
Refs: WPB-25073
…Sidebar.component.ts Refs: WPB-25073
…Sidebar.component.ts from getByTestId to getByRole Refs: WPB-25073
462aa32 to
041e425
Compare
|
markbrockhoff
approved these changes
May 4, 2026
zskhan
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The regression test suite was missing a test for the folder flow, specifically TC-742: I want to see 1:1 and group conversations in Favorites folder.
Solutions
This PR implements the missing automated test for
TC-742.It verifies the functionality and behavior of the Favorites folder. The implemented scenarios ensure:
To support these assertions, the following Page Object Models were updated:
conversationList.page.ts: AddedaddToFavoritesButtonto the context menu.conversationSidebar.component.ts: AddedfavoritesButtonlocator.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.