-
Notifications
You must be signed in to change notification settings - Fork 11
feat: implement set_client_data() [WPB-10919] #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
0695105
c0331d1
23fafcc
7a00966
7747ff0
bdd00c7
e56c0c0
8ac1aff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| CREATE TABLE consumer_data ( | ||
| id INTEGER PRIMARY KEY CHECK ( id = 0 ), | ||
| content BLOB | ||
| ); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /// Consumers of this library can use this to specify data to be persisted at the end of | ||
| /// a transaction. | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| #[cfg_attr( | ||
| any(target_family = "wasm", feature = "serde"), | ||
| derive(serde::Serialize, serde::Deserialize) | ||
| )] | ||
| pub struct ConsumerData { | ||
| pub content: Vec<u8>, | ||
| } | ||
|
|
||
| impl From<Vec<u8>> for ConsumerData { | ||
| fn from(content: Vec<u8>) -> Self { | ||
| Self { content } | ||
| } | ||
| } | ||
|
|
||
| impl From<ConsumerData> for Vec<u8> { | ||
| fn from(consumer_data: ConsumerData) -> Self { | ||
| consumer_data.content | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| use crate::{ | ||
| connection::KeystoreDatabaseConnection, | ||
| entities::{ConsumerData, Entity, EntityBase, EntityFindParams, StringEntityId, UniqueEntity}, | ||
| CryptoKeystoreResult, MissingKeyErrorKind, | ||
| }; | ||
|
|
||
| impl Entity for ConsumerData { | ||
| fn id_raw(&self) -> &[u8] { | ||
| &[Self::ID as u8] | ||
| } | ||
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl UniqueEntity for ConsumerData { | ||
| fn new(content: Vec<u8>) -> Self { | ||
| Self { content } | ||
| } | ||
|
|
||
| fn content(&self) -> &[u8] { | ||
| &self.content | ||
| } | ||
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl EntityBase for ConsumerData { | ||
| type ConnectionType = KeystoreDatabaseConnection; | ||
| type AutoGeneratedFields = (); | ||
| const COLLECTION_NAME: &'static str = "consumer_data"; | ||
|
|
||
| fn to_missing_key_err_kind() -> MissingKeyErrorKind { | ||
| MissingKeyErrorKind::ConsumerData | ||
| } | ||
|
|
||
| fn to_transaction_entity(self) -> crate::transaction::dynamic_dispatch::Entity { | ||
| crate::transaction::dynamic_dispatch::Entity::ConsumerData(self) | ||
| } | ||
|
|
||
| async fn find_all(conn: &mut Self::ConnectionType, params: EntityFindParams) -> CryptoKeystoreResult<Vec<Self>> { | ||
| <Self as UniqueEntity>::find_all(conn, params).await | ||
| } | ||
|
|
||
| async fn find_one(conn: &mut Self::ConnectionType, _id: &StringEntityId) -> CryptoKeystoreResult<Option<Self>> { | ||
| <Self as UniqueEntity>::find_one(conn).await | ||
| } | ||
|
|
||
| async fn count(conn: &mut Self::ConnectionType) -> CryptoKeystoreResult<usize> { | ||
| <Self as UniqueEntity>::count(conn).await | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| use crate::connection::DatabaseConnection; | ||
| use crate::entities::Entity; | ||
| use crate::{ | ||
| connection::KeystoreDatabaseConnection, | ||
| entities::{ConsumerData, EntityBase, EntityFindParams, StringEntityId, UniqueEntity}, | ||
| CryptoKeystoreResult, MissingKeyErrorKind, | ||
| }; | ||
|
|
||
| #[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))] | ||
| #[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)] | ||
| impl EntityBase for ConsumerData { | ||
| type ConnectionType = KeystoreDatabaseConnection; | ||
| type AutoGeneratedFields = (); | ||
| const COLLECTION_NAME: &'static str = "consumer_data"; | ||
|
|
||
| fn to_missing_key_err_kind() -> MissingKeyErrorKind { | ||
| MissingKeyErrorKind::ConsumerData | ||
| } | ||
|
|
||
| fn to_transaction_entity(self) -> crate::transaction::dynamic_dispatch::Entity { | ||
| crate::transaction::dynamic_dispatch::Entity::ConsumerData(self) | ||
| } | ||
|
|
||
| async fn find_all(conn: &mut Self::ConnectionType, params: EntityFindParams) -> CryptoKeystoreResult<Vec<Self>> { | ||
| <Self as UniqueEntity>::find_all(conn, params).await | ||
| } | ||
|
|
||
| async fn find_one(conn: &mut Self::ConnectionType, _id: &StringEntityId) -> CryptoKeystoreResult<Option<Self>> { | ||
| <Self as UniqueEntity>::find_one(conn).await | ||
| } | ||
|
|
||
| async fn count(conn: &mut Self::ConnectionType) -> CryptoKeystoreResult<usize> { | ||
| <Self as UniqueEntity>::count(conn).await | ||
| } | ||
| } | ||
|
|
||
| impl Entity for ConsumerData { | ||
| fn id_raw(&self) -> &[u8] { | ||
| &Self::ID | ||
| } | ||
|
|
||
| fn encrypt(&mut self, cipher: &aes_gcm::Aes256Gcm) -> CryptoKeystoreResult<()> { | ||
| self.content = self.encrypt_data(cipher, self.content.as_slice())?; | ||
| Self::ConnectionType::check_buffer_size(self.content.len())?; | ||
| Ok(()) | ||
| } | ||
|
|
||
| fn decrypt(&mut self, cipher: &aes_gcm::Aes256Gcm) -> CryptoKeystoreResult<()> { | ||
| self.content = self.decrypt_data(cipher, self.content.as_slice())?; | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| #[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))] | ||
| #[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)] | ||
| impl UniqueEntity for ConsumerData {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ pub mod dynamic_dispatch; | |
| use crate::entities::mls::*; | ||
| #[cfg(feature = "proteus-keystore")] | ||
| use crate::entities::proteus::*; | ||
| use crate::entities::{EntityBase, EntityFindParams, EntityTransactionExt, UniqueEntity}; | ||
| use crate::entities::{ConsumerData, EntityBase, EntityFindParams, EntityTransactionExt, UniqueEntity}; | ||
| use crate::transaction::dynamic_dispatch::EntityId; | ||
| use crate::{ | ||
| connection::{Connection, DatabaseConnection, FetchFromDatabase, KeystoreDatabaseConnection}, | ||
|
|
@@ -341,12 +341,13 @@ impl KeystoreTransaction { | |
| (identifier_12, E2eiRefreshToken), | ||
| (identifier_13, E2eiAcmeCA), | ||
| (identifier_14, E2eiIntermediateCert), | ||
| (identifier_15, E2eiCrl) | ||
| (identifier_15, E2eiCrl), | ||
| (identifier_16, ConsumerData) | ||
| ], | ||
| proteus_types: [ | ||
| (identifier_16, ProteusPrekey), | ||
| (identifier_17, ProteusIdentity), | ||
| (identifier_18, ProteusSession) | ||
| (identifier_17, ProteusPrekey), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know how these identifiers are used. Are these identifiers persisted at all? Can anything go wrong by moving
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These identifiers are merely used to hold the data from the in-memory cache before it is committed. So it doesn't matter what their name is/was at all. If we can create them internally in the macro instead of passing them in, I would like doing so!
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Creating idents like this within a macro is tricky but not impossible. In the future, it will be easier: combine the For now, |
||
| (identifier_18, ProteusIdentity), | ||
| (identifier_19, ProteusSession) | ||
| ] | ||
| ); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to enforce that
idis only ever equal to 0. Is this to enforce that there is only ever one row in the table?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly. This pattern can also be seen in other tables where we only ever expect one record, such as
e2ei_acme_ca.