chore(ts): keep browser helper imports type-only#2114
Merged
SimonThormeyer merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
SimonThormeyer
force-pushed
the
simon/fix/browser-bench-helpers
branch
3 times, most recently
from
8d08bda to
79355ec
Compare
SimonThormeyer
force-pushed
the
simon/fix/browser-bench-helpers
branch
3 times, most recently
from
3c470ae to
1ba3e3f
Compare
Browser benchmark CI loads benchmark specs through WDIO/tsx before the browser bundle is running. We need some imports from `@wireapp/core-crypto/browser` only for TypeScript annotations. However, we need to explicitly state that we want types only, otherwise the browser context will try to load symbols it doesn't have access to. This fixes the imports for `Ciphersuite`, `HttpMethod`, `HttpHeader`. This is a partial revert of be864fe. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
SimonThormeyer
force-pushed
the
simon/fix/browser-bench-helpers
branch
from
1ba3e3f to
a80f279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser benchmark CI loads benchmark specs through WDIO/tsx before the
browser bundle is running. We need some imports from
@wireapp/core-crypto/browseronly for TypeScript annotations. However,we need to explicitly state that we want types only, otherwise the
browser context will try to load symbols it doesn't have access to.
This fixes the imports for
Ciphersuite,HttpMethod,HttpHeader.What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.