Skip to content

Add PHP 8.5 to the test matrix#1489

Merged
LukeTowers merged 1 commit into
wintercms:developfrom
austinderrick:ci/php85-tests
Jun 11, 2026
Merged

Add PHP 8.5 to the test matrix#1489
LukeTowers merged 1 commit into
wintercms:developfrom
austinderrick:ci/php85-tests

Conversation

@austinderrick

@austinderrick austinderrick commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Adds PHP 8.5 to the PHPUnit test matrix on both Ubuntu and Windows.

Verified locally on PHP 8.5.5 against current develop (with winter/storm dev-develop):

Running tests for module: system
OK, but incomplete, skipped, or risky tests!
Tests: 286, Assertions: 1599, Skipped: 29.
Running tests for module: backend
OK (144 tests, 332 assertions)
Running tests for module: cms
OK (206 tests, 662 assertions)

composer lint (parallel-lint) is also clean on 8.5: Checked 1100 files in 5.1 seconds - No syntax error found.

Companion PR for the library: wintercms/storm#232

Summary by CodeRabbit

  • Chores
    • Added PHP 8.5 to the continuous integration testing matrix.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ddbf3345-bb7b-401a-a17f-10dee1fa60c3

📥 Commits

Reviewing files that changed from the base of the PR and between 4afff57 and f4d5b39.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml

Walkthrough

This PR extends the GitHub Actions workflow test matrix in .github/workflows/tests.yml to include PHP 8.5. The phpUnitTests job matrix previously tested against PHP versions 8.1, 8.2, 8.3, and 8.4. With this change, PHP 8.5 is now included in the CI test suite, expanding the range of PHP versions validated during automated testing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add PHP 8.5 to the test matrix' directly and clearly summarizes the main change in the pull request, which extends the GitHub Actions workflow to include PHP 8.5 in the CI test matrix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@LukeTowers LukeTowers merged commit 851434a into wintercms:develop Jun 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants