fix(types): restore backward-compatible TransformableInfo for logform…fix(types): restore backward-compatible TransformableInfo for logform 2.7.0+#2601
Open
samuel-adedigba wants to merge 1 commit intowinstonjs:masterfrom
Conversation
… 2.7.0+ - Re-declare TransformableInfo with 'any' instead of 'unknown' - Re-declare format namespace with compatible types - Fixes winstonjs#2528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2528
This PR restores backward compatibility for TypeScript consumers after
logform@2.7.0changedTransformableInfo.messagefromanytounknown.Changes
TransformableInfointerface withmessage: anyand index signature[key: string]: anyformatnamespace functions to use the compatibleTransformableInfotypeTransformFunctionandFormatWraptypes for custom format functionsProblem
Starting with Winston v3.17.0, valid TypeScript code like this stopped compiling:
Solution
Winston now re-declares a backward-compatible
TransformableInfothat preserves the originalanytyping, shielding consumers from the upstream breaking change.Testing
Verified TypeScript compilation with consumer-style usage patterns
All existing tests pass