Calculated default level when user gave custom levels and doesnt specify level property in logger.#2588
Open
Muhammad-Abdullah-shahzad wants to merge 3 commits intowinstonjs:masterfrom
Conversation
Author
|
@indexzero I've created a pr addressing the issue #1491.Please have a look and let me know if changes required. |
…t as default level value
…icit level calculation based on custom levels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
1.should default to low level if level not specified.
2. Default to fourth level in multi-level custom config.
3.Should default to second level if level specified.
4. should default to info level if level not specified and levels not specified
Motivation
This improves usability for developers using custom log levels without needing to explicitly set a default value.
if developer explicitly gives a level value it will override default level value.