Deep copy msg object (fix the issue: logger.info({message:...}) modifies original object)#2473
Open
Bhavesh-Parmar wants to merge 1 commit intowinstonjs:masterfrom
Open
Deep copy msg object (fix the issue: logger.info({message:...}) modifies original object)#2473Bhavesh-Parmar wants to merge 1 commit intowinstonjs:masterfrom
Bhavesh-Parmar wants to merge 1 commit intowinstonjs:masterfrom
Conversation
MrSuddenJoy
approved these changes
Jul 19, 2024
MrSuddenJoy
left a comment
There was a problem hiding this comment.
This code looks good to me. Well done 👍🏻
|
@Bhavesh-Parmar When will this fix be merged? |
Author
Thank you @MrSuddenJoy. |
Author
@olehakon really I don't know when it will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the belwo issue( resolves #1775) by deep copy the message